Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show search bar for plugin config choice field #5578

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

yakkomajuri
Copy link
Contributor

Changes

Allows searching through a plugin's config options. This will be important for plugins with a lot of choices available

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@timgl timgl temporarily deployed to posthog-pr-5578 August 13, 2021 13:28 Inactive
@yakkomajuri
Copy link
Contributor Author

This is such a tiny change but just to follow best practice I feel bad merging without a reviewer :D

Tagging you @mariusandra given @Twixes is off.

@yakkomajuri yakkomajuri requested review from mariusandra and removed request for Twixes August 16, 2021 11:47
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deliciously simple :)

@yakkomajuri yakkomajuri merged commit 1bfb20f into master Aug 17, 2021
@yakkomajuri yakkomajuri deleted the plugins-select branch August 17, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants