Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotted lines to segments of time with data still being determined #578

Merged
merged 4 commits into from
Apr 15, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Apr 14, 2020

Addresses #522

@timgl timgl temporarily deployed to posthog-522-dotted-tren-nogwog April 14, 2020 14:21 Inactive
@EDsCODE
Copy link
Member Author

EDsCODE commented Apr 14, 2020

tests from #571 are failing

@timgl
Copy link
Collaborator

timgl commented Apr 14, 2020

@EDsCODE Fixed, try rebasing master

@timgl timgl temporarily deployed to posthog-522-dotted-tren-nogwog April 14, 2020 14:32 Inactive
@EDsCODE EDsCODE requested a review from timgl April 14, 2020 14:40
@timgl
Copy link
Collaborator

timgl commented Apr 14, 2020

This breaks when selecting 'Pie'
image

@timgl timgl temporarily deployed to posthog-522-dotted-tren-nogwog April 14, 2020 15:23 Inactive
@EDsCODE
Copy link
Member Author

EDsCODE commented Apr 14, 2020

sorry! didn't notice the component was shared like that from initial impression in trends page

@timgl timgl temporarily deployed to posthog-522-dotted-tren-nogwog April 14, 2020 15:29 Inactive
@timgl timgl merged commit f3adf1d into master Apr 15, 2020
@timgl timgl deleted the #522-dotted-trend-line branch April 15, 2020 14:16
yakkomajuri added a commit that referenced this pull request Oct 1, 2021
* truncate test tables instead of delete

* also truncate ee_hook

* batch, cascade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants