703 multiple dashboards #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgl
reviewed
May 11, 2020
timgl
reviewed
May 11, 2020
timgl
reviewed
May 11, 2020
|
Hi, I fixed all the points, except for the sidebars, where I left a comment and propose to keep it like this for a bit and perhaps update within a week. |
timgl
approved these changes
May 11, 2020
fuziontech
added a commit
to fuziontech/posthog
that referenced
this pull request
May 11, 2020
* upstream/master: Closes PostHog#169 break down by cohort (PostHog#690) 703 multiple dashboards (PostHog#740) Use person_id instead of distinct_id for unique count (PostHog#734) new contributors (PostHog#739) Update Trends dotted line UX (PostHog#735)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #703 .
This turned into a rather big PR again. It adds support for multiple dashboards and improves a bunch of other stuff:
Other things added:
promptlogic that lets you askwindow.promptstyle questions easily from within a logic, including support for closing the prompt modal when the logic that asks the question is unmounted (e.g. you click "new dashboard" and then click back in the browser and go to another page)loaderloads for more than 0.5 sec, we also display a line on top of the page with nprogress, to give better indication to the user that something is happening. This gives a bit of feedback during long running queries when there is no obvious "loading" spinner on the page.There's also one hidden feature in this PR
There's only one problem.
mypygives me some error and I'm not sure what to do about it. @timgl any thoughts?I'm also not 100% sure of the django code, so please check and feedback :).
Checklist