Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black dashboard items and Full Screen #753

Merged
merged 20 commits into from
May 14, 2020
Merged

Black dashboard items and Full Screen #753

merged 20 commits into from
May 14, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

  • Adds support for black dashboard panels
  • Adds full screen button

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)

@mariusandra mariusandra requested a review from timgl May 13, 2020 12:24
@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 13, 2020 12:25 Inactive
@mariusandra mariusandra force-pushed the black-dashboards-and-full-screen branch from 482eb8f to fd0e7af Compare May 13, 2020 12:40
@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 13, 2020 12:40 Inactive
@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 13, 2020 13:24 Inactive
@mariusandra
Copy link
Collaborator Author

This PR could already be merged to already some more dashboard issues fixed in master.

@mariusandra mariusandra force-pushed the black-dashboards-and-full-screen branch from 33bca76 to 0aa9adc Compare May 13, 2020 14:37
@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 13, 2020 14:37 Inactive
@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 13, 2020 15:00 Inactive
@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 13, 2020 15:01 Inactive
@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 13, 2020 16:16 Inactive
@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 13, 2020 19:16 Inactive
timgl
timgl approved these changes May 13, 2020
View reviewed changes
frontend/src/scenes/dashboard/dashboardLogic.js Outdated Show resolved Hide resolved
@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 13, 2020 20:54 Inactive
@timgl
Copy link
Collaborator

timgl commented May 13, 2020

LGTM

@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 13, 2020 22:16 Inactive
@mariusandra
Copy link
Collaborator Author

Thanks! I had to add one more rather complicated piece of code (57a3f7b) to fix alignment issues.

This is one of the more important points from #752.

Rather than explain, here are screencasts:

Before:
screencast 2020-05-14 00-15-03

After:
screencast 2020-05-14 00-10-26

The "before" behaviour was there no matter if you added the chart from the funnel/trends page, copied/moved the element or just duplicated it. I think it was totally worth the effort :).

If looks good, I'll merge.

Just touch input and edit item to go and the dashboards are done.

@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 14, 2020 10:05 Inactive
@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 14, 2020 10:25 Inactive
@timgl timgl temporarily deployed to posthog-black-dashboard-rz7mfg May 14, 2020 10:32 Inactive
@timgl
Copy link
Collaborator

timgl commented May 14, 2020

LGTM

@timgl timgl merged commit 95c7608 into master May 14, 2020
@timgl timgl deleted the black-dashboards-and-full-screen branch May 14, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl timgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariusandra @timgl