Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix property filter array issue on events page #769

Merged
merged 2 commits into from
May 14, 2020
Merged

Fix property filter array issue on events page #769

merged 2 commits into from
May 14, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

Fixes this case where if there was a filter active and you clicked on something in the events list to filter even more, the page crashed:

screencast 2020-05-14 09-08-31

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)

@mariusandra mariusandra requested a review from timgl May 14, 2020 07:26
@timgl timgl temporarily deployed to posthog-fix-events-prop-obm3dg May 14, 2020 11:10 Inactive
@timgl timgl merged commit 2fc5068 into master May 14, 2020
@timgl timgl deleted the fix-events-properties-array branch May 14, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl timgl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariusandra @timgl