Fix "max number of clients reached" errors and perf improvements #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgl
changed the title
EDsCODE
approved these changes
May 19, 2020
| try: | ||
| team_id = Team.objects.only('pk').get(api_token=token).pk | ||
| if team_id: | ||
| TEAM_ID_CACHE[token] = team_id |
There was a problem hiding this comment.
does this cache ever get flushed?
There was a problem hiding this comment.
It does when the server gets restarted. However the token is fairly static, I don't think there'd be many situations you'd change it
| @@ -20,6 +20,10 @@ | |||
| # Load task modules from all registered Django app configs. | |||
| app.autodiscover_tasks() | |||
|
|
|||
| # Make sure Redis doesn't add too many connections | |||
| # https://stackoverflow.com/questions/47106592/redis-connections-not-being-released-after-celery-task-is-complete | |||
| app.conf.broker_pool_limit = 0 | |||
There was a problem hiding this comment.
makes sense. curious if needing to open and close connections will become a bottleneck anyway but the load testing seems to hold up
There was a problem hiding this comment.
Hm yes I think it does slow it down a little bit but at least it works, especially with the cheaper Redis instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This should solves Daz's issues
Before, Celery would be spinning up too many connections to Redis if many events were inserted.
See load test:
Error message:
Load testing
With 1 Standard-1x web dyno I was able to achieve on average 20/sec
With 2 Standard-2x web dynos I was able to achieve 44/sec
After caching Teams, no real difference though lower response times and memory load
Each time, Redis would use about 21 connections so the advice would be to get a Redis server with slightly more connections.
Checklist