refactor(utils): Consolidate number formatting #9733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkus
approved these changes
May 11, 2022
alexkim205
pushed a commit
that referenced
this pull request
May 23, 2022
* refactor(utils): Consolidate number formatting * Use unbreakable space * Use comma as thousands separator * Update utils.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Stepping on toes a little bit to consolidate
humanFriendlyNumber()andmaybeAddCommasToInteger(), which were used almost interchangeably to format numbers following #9725. Only the former is now used. The comma is used as thousands separator. I was earlier in favor of using the space but sadly that doesn't look as readable in more cramped contexts (such as the trends tooltip).