New Post - Get Yesterday's Date #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasNieto
reviewed
Feb 21, 2021
ThomasNieto
reviewed
Feb 21, 2021
ThomasNieto
reviewed
Feb 21, 2021
ThomasNieto
reviewed
Feb 21, 2021
ThomasNieto
reviewed
Feb 22, 2021
ThomasNieto
reviewed
Feb 22, 2021
Great catches from code review - thanks Co-authored-by: Thomas Nieto <38873752+ThomasNieto@users.noreply.github.com>
Added comment about immutability of DateTime object. Thanks for the catch.
|
@ThomasNieto thanks for the review. I have addressed each of your points (hopefully) and thanks for the comments. I hope this is ready to go! |
ThomasNieto
reviewed
Feb 22, 2021
Co-authored-by: Thomas Nieto <38873752+ThomasNieto@users.noreply.github.com>
|
Hopefully ready to go. |
|
Can someone merge this as I am not allowed to! |
|
So I have updated the section based on Thomas Nieto's comments regarding using ToString. I hope the updated text reads better. |
ThomasNieto
approved these changes
Feb 25, 2021
sdwheeler
requested changes
Feb 25, 2021
sdwheeler
requested changes
Feb 25, 2021
sdwheeler
reviewed
Feb 25, 2021
sdwheeler
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This shows how to get yesterday's date and how to use it.
Addresses issue #8.
PR Checklist