Add Pgp signing template #15
Conversation
| $fileName = $file.Name | ||
| Move-Item -Path "${{ parameters.buildOutputPath }}\$fileName" -Dest "$(Agent.TempDirectory)\$fileName" | ||
| Write-Host "##vso[artifact.upload containerfolder=signingReport;artifactname=signingReport]$(Agent.TempDirectory)\$fileName" | ||
| Copy-Item -Path ${{ parameters.buildOutputPath }}\* -Dest ${{ parameters.signOutputPath }}\ -Recurse -Force -Verbose |
There was a problem hiding this comment.
Should the copy happen before the ESRP task so we can have unsigned files still in buildOutputPath?
There was a problem hiding this comment.
This is a behavior change. I can work on this after I get this work done.
I think this makes sense
There was a problem hiding this comment.
One thing, is we might end up with unsigned files in the signed folder.
| Write-Host "##$vstsCommandString" | ||
| displayName: Generate signing JSON | ||
| displayName: Generate Authenticode signing JSON | ||
| condition: and(and(and(succeeded(), eq(variables['Build.Reason'], 'Manual')), ne(variables['SkipSigning'], 'True')), ne(variables['SigningServer'], '')) |
There was a problem hiding this comment.
this seems to be the same calculation as in EsrpSign. Is there someway to have only a single instance of this calculation be shared between files?
There was a problem hiding this comment.
The best I can think of is to pass it in as parameter and it causes issues. I'll file a feature request for step templates to be conditional.
| Write-Verbose -Message ("sending " + $vstsCommandString) -Verbose | ||
| Write-Host "##$vstsCommandString" | ||
| displayName: Generate PGP signing JSON | ||
| condition: and(and(and(succeeded(), eq(variables['Build.Reason'], 'Manual')), ne(variables['SkipSigning'], 'True')), ne(variables['SigningServer'], '')) |
There was a problem hiding this comment.
yep - and here is that calculation again
There was a problem hiding this comment.
unfortunately, we tried doing the calculation one time and it causes issues
Add Pgp signing template