Skip to content

Calculate the conditions once #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 9, 2020
Merged

Calculate the conditions once #23

merged 4 commits into from
Dec 9, 2020

Conversation

TravisEz13
Copy link
Member

Calculate the conditions once

Also:

  • Allow specifying ShouldSign as a param
  • Add alwaysCopy parameter which cause the sign task to always copy even if it doesn't sign.
  • make signing service name a param (other teams are planning on using this repo)

@TravisEz13 TravisEz13 marked this pull request as ready for review December 9, 2020 22:02
@TravisEz13 TravisEz13 merged commit ebdbd44 into master Dec 9, 2020
@TravisEz13 TravisEz13 deleted the consolidate-conditions branch December 9, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@JamesWTruher JamesWTruher JamesWTruher approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TravisEz13 @JamesWTruher