Skip to content

Add flexibility to ESRP signing and scanning tasks #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 22, 2021
Merged

Add flexibility to ESRP signing and scanning tasks #27

merged 10 commits into from
Jan 22, 2021

Conversation

spaceisfun
Copy link
Contributor

@spaceisfun spaceisfun commented Jan 21, 2021 •
edited
Loading

  • Improved logging.
  • Param to use custom signing JSON
  • Param to run signtool /verify after signing
  • Param to enable/disable page hash signing
  • Param to use different ESRP scan service name

@spaceisfun spaceisfun changed the title Testcustom Add flexibility to ESRP signing and scanning tasks Jan 21, 2021
@spaceisfun spaceisfun marked this pull request as ready for review January 21, 2021 17:33
@spaceisfun spaceisfun mentioned this pull request Jan 21, 2021
Merged
TravisEz13
TravisEz13 requested changes Jan 21, 2021
View reviewed changes
@spaceisfun spaceisfun requested a review from TravisEz13 January 21, 2021 18:42
@TravisEz13
Copy link
Member

@JamesWTruher Please review

JamesWTruher
JamesWTruher reviewed Jan 22, 2021
View reviewed changes
Copy link
Contributor

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of questions

@TravisEz13 TravisEz13 merged commit aae1bd4 into PowerShell:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

+1 more reviewer

@JamesWTruher JamesWTruher JamesWTruher left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaceisfun @TravisEz13 @JamesWTruher