Skip to content

Fix ‘TermCheck’ template to accept path parameter and enable recursion #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Fix ‘TermCheck’ template to accept path parameter and enable recursion #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82ae348
Add `targetArgument` to ‘TermCheck’
andyleejordan Feb 2, 2021
7db8ed0
Don’t set `optionsXS` to 0 so as to re-enable recursion
andyleejordan Feb 3, 2021
9005ae0
Add `optionsUEPATH` to TermCheck for “user exclusions”
andyleejordan Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ The following sample shows how the templates can be included in your release YAM
sourceScanPath: '$(Build.SourcesDirectory)'
# credscan
suppressionsFile: ''
# TermCheck
# TermCheck AKA PoliCheck
targetArgument: '$(Build.SourcesDirectory)'
optionsUEPATH: ''
optionsRulesDBPath: ''
optionsFTPath: ''
# tsa-upload
Expand All @@ -60,6 +62,8 @@ The following sample shows how the templates can be included in your release YAM
APIScan: false # set to false when not using Windows APIs.
```

For “TermCheck” see the [wiki](https://www.1eswiki.com/wiki/PoliCheck_Build_Task).

## ESRP Signing Template Overview

** Requires on-boarding, see the wiki in the internal PowerShell Maintainers teams channel **
Expand Down Expand Up @@ -184,7 +188,7 @@ This example signs `pkg` files recursively, using minimatch.
```

### ESRP custom signing JSON example
1. Set the build variable ESRP_TEMPLATE_CUSTOM_JSON to your desired ESRP JSON string.
1. Set the build variable `ESRP_TEMPLATE_CUSTOM_JSON` to your desired ESRP JSON string.
2. Call EsrpSign.yml@ComplianceRepo with certificateId: "" and useCustomEsrpJson: true.

```yaml
Expand Down Expand Up @@ -299,4 +303,4 @@ This example uses a custom ESRP malware scanning (Azure DevOps) service name.
**\*.dll
scanningService: 'FactoryOrchestratorScanning'

```
```
4 changes: 4 additions & 0 deletions assembly-module-compliance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ parameters:
# credscan
suppressionsFile: ''
# TermCheck
targetArgument: '$(Build.SourcesDirectory)'
optionsUEPATH: ''
optionsRulesDBPath: ''
optionsFTPath: ''
# tsa-upload
Expand Down Expand Up @@ -45,6 +47,8 @@ steps:

- template: template-compliance/TermCheck.yml
parameters:
targetArgument: ${{ parameters.targetArgument }}
optionsUEPATH: ${{ parameters.optionsUEPATH }}
optionsRulesDBPath: ${{ parameters.optionsRulesDBPath }}
optionsFTPath: ${{ parameters.optionsFTPath }}

Expand Down
4 changes: 4 additions & 0 deletions script-module-compliance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ parameters:
# credscan
suppressionsFile: ''
# TermCheck
targetArgument: '$(Build.SourcesDirectory)'
optionsUEPATH: ''
optionsRulesDBPath: ''
optionsFTPath: ''
# tsa-upload
Expand All @@ -26,6 +28,8 @@ steps:

- template: template-compliance/TermCheck.yml
parameters:
targetArgument: ${{ parameters.targetArgument }}
optionsUEPATH: ${{ parameters.optionsUEPATH }}
optionsRulesDBPath: ${{ parameters.optionsRulesDBPath }}
optionsFTPath: ${{ parameters.optionsFTPath }}

Expand Down
7 changes: 5 additions & 2 deletions template-compliance/TermCheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
parameters:
targetArgument: '$(Build.SourcesDirectory)'
optionsUEPATH: ''
optionsRulesDBPath: ''
optionsFTPath: ''

Expand All @@ -7,11 +9,12 @@ steps:
displayName: 'Run TermCheck'
inputs:
targetType: F
targetArgument: ${{ parameters.targetArgument }}
optionsFC: 0
optionsXS: 0
optionsPE: '1|2|3|4'
optionsHMENABLE: 0
optionsUEPATH: ${{ parameters.optionsUEPATH }}
optionsRulesDBPath: ${{ parameters.optionsRulesDBPath }}
optionsFTPATH: ${{ parameters.optionsFTPath }}
toolVersion: Latest
continueOnError: true
continueOnError: true