Skip to content

add daily build compliance template #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 3, 2021
Merged

add daily build compliance template #32

merged 7 commits into from
Mar 3, 2021

Conversation

TravisEz13
Copy link
Member

No description provided.

adityapatwardhan
adityapatwardhan approved these changes Mar 3, 2021
View reviewed changes
@adityapatwardhan adityapatwardhan merged commit c6f7be0 into master Mar 3, 2021
@TravisEz13 TravisEz13 deleted the dailyBuildComp branch March 4, 2021 00:37
JamesWTruher
JamesWTruher reviewed Mar 4, 2021
View reviewed changes
Copy link
Contributor

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be ok, however, we should perhaps expect compliance/component issues in our daily build which are not caught in CI/PR (such as new functionality which uses a new component). I'm not sure there's a reasonable alternative, though.

@TravisEz13
Copy link
Member Author

The task doesn't fail on an issue. It only sends me a weekly report. So, running daily should be more than adequate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

+1 more reviewer

@JamesWTruher JamesWTruher JamesWTruher left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TravisEz13 @JamesWTruher @adityapatwardhan