Fix expression grammar to work with boolean functions #1144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The grammar didn't allow for functions
true()
andfalse()
and only expected boolean argumentstrue
andfalse
so this resulted in a parsing error. Fix is to update the grammar with precedence for functions and booleans (in that order) so thattrue()
andfalse()
will be accepted as function names and not treated as booleans and thus invalidating the rest of the expression.Some of the invalid tests needed to be updated, but all still result in an error as expected.
PR Context
Fix #1136