Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add run command resource #321

Merged
merged 27 commits into from
Mar 5, 2024
Merged

Add run command resource #321

merged 27 commits into from
Mar 5, 2024

Conversation

tgauth
Copy link
Collaborator

@tgauth tgauth commented Feb 21, 2024 •
edited
Loading

PR Summary

PR Context

  • adds RunCommandOnSet resource, without tracing for stdout/stderr propagated back to DSC

@tgauth tgauth marked this pull request as ready for review February 22, 2024 20:16
SteveL-MSFT
SteveL-MSFT requested changes Feb 22, 2024
View reviewed changes
runcommandonset/RunCommandOnSet.dsc.resource.json Outdated Show resolved Hide resolved
runcommandonset/RunCommandOnSet.dsc.resource.json Outdated Show resolved Hide resolved
runcommandonset/src/utils.rs Outdated Show resolved Hide resolved
runcommandonset/tests/runcommandonset.get.tests.ps1 Outdated Show resolved Hide resolved
runcommandonset/tests/runcommandonset.set.tests.ps1 Outdated Show resolved Hide resolved
runcommandonset/tests/runcommandonset.set.tests.ps1 Outdated Show resolved Hide resolved
runcommandonset/tests/runcommandonset.set.tests.ps1 Show resolved Hide resolved
SteveL-MSFT
SteveL-MSFT requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address the comments

SteveL-MSFT
SteveL-MSFT requested changes Mar 5, 2024
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor feedback

runcommandonset/src/runcommand.rs Outdated Show resolved Hide resolved
runcommandonset/tests/runcommandonset.set.tests.ps1 Show resolved Hide resolved
@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Mar 5, 2024
Merged via the queue into PowerShell:main with commit f345fef Mar 5, 2024
4 checks passed
@tgauth tgauth deleted the add-run-command-resource branch March 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees
No one assigned
Labels
Doc-Impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RunCommand resource
2 participants
@tgauth @SteveL-MSFT