Fix Assertion resource to fail when test fails
#736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2025 17:22
tgauth
reviewed
Apr 4, 2025
tgauth
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
A previous PR that cleaned up the output of
Assertionto fit withgetandsetcaused the assertion to never actually fail, just return results in the desired format.The change here is to add a new hidden switch
--as-assertso thatdscknows it's running asAssertion. Then when this is used it checks each test result and if any are NOT in desired state, it returns an error that the assertion failed. Many of the changes is just to pass this parameter to the necessary functions. A helper function is used to potentially recursively look at all theinDesiredStateproperties.PR Context
Fix #731