Fix WinPS adapter hidden properties #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gijsreyn in general, you should have clippy fixes as a completely separate PR. I create a PR for clippy fixes so you should revert those changes here and update your branch when that PR is merged |
|
I made note of it, and the clippy fixes are removed. Thanks for updating it in a separate PR. It should be good to go now. |
|
@Gijsreyn can you fix the merge conflict? |
SteveL-MSFT
requested changes
Jun 3, 2025
SteveL-MSFT
reviewed
Jun 4, 2025
SteveL-MSFT
approved these changes
Jun 4, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR addresses #832 and some minor clippy issues.
PR Context