Skip to content

also scope the \n at the end of line comments as comment.line #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

keith-hall
Copy link
Contributor

Fixes #123.

Note that it doesn't seem possible to create a test assertion for it until #124 is addressed, as atom-grammar-test doesn't seem to support tokens on \n characters - when I try, I just get an error:

Expected to find comment.line.powershell at 769:34, instead found no token

@omniomi
Copy link
Contributor

omniomi commented Jul 26, 2018

LGTM, we can include it in the sublime tests.

I'm moving Monday so 70% of my stuff is in boxes right now and the other 30% needs to be put in boxes so it will be at least a week before I circle around to it which gives @tylerl0706 time to figure out the copyright part.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TylerLeonhardt TylerLeonhardt merged commit 472c944 into PowerShell:master Jul 26, 2018
@keith-hall keith-hall deleted the line_comments branch July 26, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants