-
Notifications
You must be signed in to change notification settings - Fork 52
Tools and docs #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools and docs #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉 Just a small edit and I need to register the 3rd party lib - I'll take care of that tomorrow.
This should help boost contributions 😀
tools/scripts/build-grammar.js
Outdated
/*--------------------------------------------------------------------------------------------- | ||
* Licensed under the MIT License. See License.txt in the project root for license information. | ||
* | ||
* Modified for PowerShell\EditorSyntax from MicroSoft\vscode (update-grammar.js) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MicroSoft -> Microsoft
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
}, | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"fast-plist": "0.1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to register that we are using this library (internal process). I'm expecting it to be approved quickly but I wanted to let you know. It might take a day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it helps fast-plist was written by Microsoft https://github.com/Microsoft/node-fast-plist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well that makes things a lot easier
Ok all registered :) merging this in! |
Honestly, I wish the script was written in PowerShell, but since vscode did it in node already, seems fine. We should open an issue to rewrite it in PowerShell (super low pri) so people don't need that Node dependency. |
@tylerl0706, I was thinking the same thing and I did mock up something last night before eventually falling back to Node.js. The plist format was giving me a headache. That said, the plan is to eventually finish what I started and bundle it as |
Sounds good! A ConvertFrom-Plist would be really helpful as a standalone module actually. Lots of stuff in the macOS world use plists. |
Added a build script that generates the json grammar file used by VS Code. I adapted the script used by Microsoft/vscode to work with a local file but it otherwise generates the output in much the same way.
Added build steps (VS Code specific for now) to the readme. These can later be moved to the Wiki or a child docs folder.
Added an issue template.
There are no changes to the actual syntax definitions in this branch. These tools are designed to make it easier for others to test changes.