PSReadine doesnt clear multiline text when Escape pressed

[MVKozlov]

Environment data

PS version: 5.1.14409.1012
PSReadline version: 2.0.0
os: 6.1.7601.17514 (win7sp1_rtm.101119-1850)
PS file version: 10.0.14409.1005 (rs1_srvoob.161208-1155)

Steps to reproduce or exception report

1. Write any long text into cmdline (it mush be longer than one line)
2. Press Escape key
3. PSReadline should clear all command text but clear only first line

[lzybkr]

Strange, I've been self hosting for months and should have noticed this. It will be a few days before I can take a look.

[MVKozlov]

Tested on another WIn7, same effect
on Win10 all ok

[MVKozlov]

I addition: Powershell shutdown/unload time on 2.0 up to 6-7 sec :(

[lzybkr]

Please open another issue and include some details like how you close PowerShell and the versions of Windows and PowerShell where you see this behavior.

[lzybkr]

I have reproduced the problem on Win7 as well as Win10 in legacy mode.

There is a difference in how conhost handles Console.WriteLine() when at the end of the line. I'll think more about a fix - and hopefully this difference doesn't come up elsewhere - I think it came up in menu completion (which is fixed now) but I don't think the same fix will work here.

[MVKozlov]

Back to old problem :)
this diff fixes rendering on win7 and I do not see any difference of WinSrv2016. It doesn't break anything (I try to check it on Win10 later)

Do not try any Linuxes, may be it need to tune up

--- Render~orig.cs      Tue Nov 06 11:49:37 2018
+++ Render.cs   Tue Nov 06 11:48:58 2018
@@ -486,7 +486,7 @@

             while (previousPhysicalLine > physicalLine)
             {
-                _console.Write("\n");
+                //_console.Write("\n");
                 physicalLine += 1;
                 var lenToClear = physicalLine == previousPhysicalLine ? lenPrevLastLine : bufferWidth;
                 if (lenToClear > 0)

May be I don't uderstand something but it just works :O

[lzybkr]

Feel free to submit a PR.

[MVKozlov]

I'll wait until I'm at least understand what this code should do and test it on win10/linuxes :)

[s-shamesmuhametov-parc]

It also reproduced on my Windows 8.1. When I navigate through my history containing multi-line commands
Commenting line _console.Write("\n"); helps. Thanks @MVKozlov
It would be good to fix it PR