Skip to content

Remove MIT License, move License.txt to root, update build script #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Apr 4, 2020

Microsoft Reviewers: Open in CodeFlow

@SteveL-MSFT SteveL-MSFT requested a review from daxian-dbw April 4, 2020 01:51
@daxian-dbw
Copy link
Member

daxian-dbw commented Apr 4, 2020

@SteveL-MSFT License.txt still has Copyright (c) 2013, Jason Shirk as the first line. Should that be changed to Copyright (c) Microsoft Corporation?

@iSazonov
Copy link

iSazonov commented Apr 4, 2020

Isn't the project now under MIT license?

@daxian-dbw
Copy link
Member

@iSazonov After consulting with the corporate attorney, it's been decided to keep the original BSD license for PSReadLine.

@iSazonov
Copy link

iSazonov commented Apr 4, 2020

@daxian-dbw Thanks! Should we add this ("BSD license") in the file, readme and GitHub repo description explicitly?
Also the PR description could be "Replace MIT license with BSD..."

@daxian-dbw
Copy link
Member

I need to confirm with @joeyaiello on whether I should refresh all files with a new header that calls out the BSD license. As for the repo itself, the readme.md already calls out the license, at the end.

@iSazonov
Copy link

iSazonov commented Apr 4, 2020

Also MSFT could want to preserve Jason's copyright and add MSFT copyright.

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR to resolve conflicts.
I will go merging this PR. If we need to update the license.txt I will submit a new PR.

@daxian-dbw daxian-dbw merged commit 60bd4c0 into PowerShell:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants