Skip to content

Limit the folder for APIScan #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Aug 5, 2020

PR Summary

The API Scan step took a very long time, usually nearly 3 hours. It's very easy to get timeout in release build with the current setting. This PR limits the source folder for API Scan to the bin folder that contains the artifacts that are part of the final module, so we can bring the API Scan time down to around 30 minutes.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests NA
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit 804e7a0 into PowerShell:master Aug 5, 2020
@daxian-dbw daxian-dbw deleted the apiscan branch August 5, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant