Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vi-mode] Deleting backward to|until a character preserves the character under the cursor #2007

Merged
merged 2 commits into from Dec 7, 2020

Conversation

springcomp
Copy link
Contributor

@springcomp springcomp commented Dec 2, 2020

PR Summary

Fixes #1674.

In Vi mode, deleting to backward text should not remove the character under (at the right) of the cursor. This PR adjusts the boundary used by the DeleteBackwardToEndPoint to preserve the last (starting) character.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not expecting documentation change.
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit 1f6c5c0 into PowerShell:master Dec 7, 2020
@ghost
Copy link

ghost commented Feb 23, 2021

🎉 v2.2.0-beta2 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vi-mode] Backwards delete removes the character under the cursor, which is incorrect
2 participants