Skip to content

Add GitHub Action to pre-triage new issues #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jan 10, 2021

PR Summary

Add a GitHub Action to pre-triage new issue -- close the issues that are duplicate of #1306 and #1315

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit d06c417 into PowerShell:master Jan 10, 2021
@daxian-dbw daxian-dbw deleted the action branch January 10, 2021 05:51
@iSazonov
Copy link

Bot war! 😄 Need to add auto issue creation in PSReadline 😄

@iSazonov
Copy link

Hmm, why not? If implement this reporting by telemetry users will do not create useless issues. Workflow would be: PSReadline error -> send a telemetry -> filter the telemetry -> create new issue only if needed.

@daxian-dbw
Copy link
Member Author

Nice idea 👍 Most of the duplicate issues are reported against the old versions of PSReadLine, so the bot is still needed. As for your suggestion, the user interaction is still important because repro steps are important for us to really investigate the issue.

@iSazonov
Copy link

the user interaction is still important because repro steps are important for us to really investigate the issue.

I'd speculate 95% questions is about user environment. I believe it makes sense to enhance the trace error report with the information (terminal, its geometry, font, code page and so on).

As for user interaction, we could add a correlation id in the trace - if an user open new issue manually (copy-paste from screen or share screenshot) you could use the correlation id to search auto report in trace database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants