Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering when continuation prompt is an empty string #2875

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Sep 19, 2021

PR Summary

Fix #2723

Fix physical line calculation when the logical line is empty. This could happen when the continuation prompt gets set to be an empty string. Also, in RenderOneChar, avoid adding the color continuation prompt color ANSI codes when the continuation prompt is an empty string.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit 078a2b3 into PowerShell:master Sep 20, 2021
@daxian-dbw daxian-dbw deleted the empty-cont branch September 20, 2021 16:26
@ghost
Copy link

ghost commented Oct 28, 2021

🎉 v2.2.0-beta4 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty continuation prompt breaks text placement near bottom of window
1 participant