Skip to content

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Sep 20, 2021

PR Summary

Fix #2348

Two changes:

  1. Fix GotoBrace to handle the case when the text buffer is empty
  2. Use Unix line ending in movement.vi.cs instead of mix of LF and CRLF

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit d375997 into PowerShell:master Sep 20, 2021
@daxian-dbw daxian-dbw deleted the gotobrace branch September 20, 2021 20:49
@ghost
Copy link

ghost commented Oct 28, 2021

🎉 v2.2.0-beta4 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.IndexOutOfRangeException: Index was outside the bounds of the array
1 participant