Skip to content

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jul 6, 2022

PR Summary

Fix #3347

Avoid triggering the list view prediction when the first line was scrolled up off the screen buffer.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw requested a review from andyleejordan July 6, 2022 21:01
@daxian-dbw daxian-dbw merged commit bbbe43b into PowerShell:master Jul 8, 2022
@daxian-dbw daxian-dbw deleted the list branch July 8, 2022 22:32
@daxian-dbw
Copy link
Member Author

Thanks @andschwa for the review!

@ghost
Copy link

ghost commented Mar 8, 2023

🎉 v2.3.0-beta0 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception in a continuation prompt context with PredictionSource as HistoryAndPlugin and PredictionViewStyle as ListView
2 participants