Skip to content

Change Default member color back to original default of gray #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

StevenBucher98
Copy link
Collaborator

@StevenBucher98 StevenBucher98 commented Oct 17, 2022

PR Summary

Making member color go to default member color instead of default number color. This changes member color to be Brought to attention by #3445

Changes current member color from white to grey. Originally in the code DefaultMemberColor is ConsoleColor.Gray and seems to just be a typo mistake. If this was intentional we can ignore this PR.

cc: @daxian-dbw @theJasonHelmick

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

Making member color go to default member color instead of default number color
@StevenBucher98 StevenBucher98 changed the title Update Cmdlets.cs Change Default member color back to original default of gray Oct 17, 2022
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Mar 8, 2023

🎉 v2.3.0-beta0 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants