Skip to content

Set the current location in PredictionClient when it's supported #3639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2023
Merged

Set the current location in PredictionClient when it's supported #3639

merged 2 commits into from
Mar 29, 2023

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Mar 27, 2023 •
edited
Loading

PR Summary

Set the current location in PredictionClient when it's supported.
This is in accordance with PowerShell/PowerShell#19414, which adds the property CurrentLocation to PredictionClient, so as to make it easy for a predictor implementation to know the current location.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw mentioned this pull request Mar 27, 2023
Merged
13 tasks
andyleejordan
andyleejordan approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long my reflection understanding is right.

SeeminglyScience
SeeminglyScience approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daxian-dbw
Copy link
Member Author

Thank both of you for the review!

@daxian-dbw daxian-dbw merged commit d6efcab into PowerShell:master Mar 29, 2023
@daxian-dbw daxian-dbw deleted the path branch April 4, 2023 05:07
@ghost
Copy link

ghost commented May 3, 2023

🎉 v2.3.1-beta1 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxian-dbw @andyleejordan @SeeminglyScience