Avoid running AddToHistoryHandler on command lines loaded from history file
#3643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
approved these changes
Apr 6, 2023
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When using a somewhat non-trivial
AddToHistoryHandlerin profile, a session started with the profile will be unresponsive for a few seconds because when loading history items from the history file, PSReadLine callsAddToHistoryHandleron each of the items to get theAddToHistoryOptionfor this item (SkipAdding,MemoryOnly,MemoryAndFile). This is unnecessary because those items are read from history file, meaning they have already been saved to the history file.This PR fix the issue by avoiding running
AddToHistoryHandleron command lines loaded from history file.PR Checklist
Microsoft Reviewers: Open in CodeFlow