Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append reset VT sequence before rendering the inline prediction #3669

Merged
merged 1 commit into from May 3, 2023

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented May 3, 2023

PR Summary

Append reset VT sequence before rendering the inline prediction, so as to reset any VT decorations customized by a user when rendering the inline view.

Before the fix, gcm -N shows the following inline prediction -- the VT decoration for the parameter leaks to the inline view.

image

After the fix, gcm -N shows the following:

image

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit 0032acb into PowerShell:master May 3, 2023
2 checks passed
@daxian-dbw daxian-dbw deleted the inline branch May 3, 2023 05:20
@ghost
Copy link

ghost commented May 3, 2023

🎉 v2.3.1-beta1 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant