Work around InvalidOperationExceptions from Console API #3755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses PowerShell#3744 There is a problem with the .NET Console API, described in this Issue: dotnet/runtime#88697 This change works around the problem by handling the InvalidOperationException that might spuriously fly out of KeyAvailable and ReadKey (with a limited number of retries, in case there is something *else* pathological going on).
This was referenced Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Addresses #3744
There is a problem with the .NET Console API, described in this Issue:
This change works around the problem by handling the InvalidOperationException that might spuriously fly out of KeyAvailable and ReadKey (with a limited number of retries, in case there is something else pathological going on).
PR Checklist
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/PowerShell/PSReadLine/pull/3755&drop=dogfoodAlpha