Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct directory separator based on the platform we are working with #3935

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jan 31, 2024

PR Summary

Fix #3923

When working with a remote Runspace, we choose the directory separator based on the platform of the remote server.

Before the fix, the trailing directory separator is \ in a remote session from Windows to Linux

old

**After the fix, the trailing directory separator is / in a remote session from Windows to Linux

new

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests tested manually
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@daxian-dbw daxian-dbw merged commit 5fa2a21 into PowerShell:master Feb 1, 2024
2 checks passed
@daxian-dbw daxian-dbw deleted the separator branch February 1, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected backslashes when remoting from Win to Nix
2 participants