Skip to content

Use CFS for installing module and deploy box for module publish #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

Use CFS for installing module and deploy box for module publish #4700

merged 3 commits into from
Apr 14, 2025

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Apr 10, 2025 •
edited
Loading

PR Summary

This PR includes the following changes:

  1. Use CFS feed for installing module from gallery.
  2. Use deploy box for module publishing.
  3. Add pipeline parameter to control whether to release
  4. Handle bootstrap explicitly
  5. Use 'server' instead of 'agentless'

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

jshigetomi
jshigetomi reviewed Apr 10, 2025
View reviewed changes
jshigetomi
jshigetomi reviewed Apr 10, 2025
View reviewed changes
jshigetomi
jshigetomi reviewed Apr 10, 2025
View reviewed changes
@daxian-dbw
Address comments:
5402741 
1. Add pipeline parameter to control whether to release
2. Handle bootstrap explicitly
3. Use 'server' instead of 'agentless'
jshigetomi
jshigetomi approved these changes Apr 14, 2025
View reviewed changes
Copy link

@jshigetomi jshigetomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit 4a2bf98 into PowerShell:master Apr 14, 2025
2 checks passed
@daxian-dbw daxian-dbw deleted the deploy-box branch April 14, 2025 23:57
@daxian-dbw daxian-dbw mentioned this pull request Apr 15, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

+1 more reviewer

@jshigetomi jshigetomi jshigetomi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxian-dbw @TravisEz13 @jshigetomi