Loose the check for dead keys #939
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #933, I tried to use the win32 API
ToUnicode
to check for dead keys -- according to the documentation, if the return value is-1
or>=2
, the key is most likely a dead key.However, it turns out
ToUnicode
is not reliable when the keyboard is not natively supported by Windows. For example, with the Neo keyboard,ToUnicode
seems to return 0 for dead keys. So the fix could be to loose the check for dead keys -- treat a key as a dead key as long asToUnicode
failed to translate.I haven't set up the Neo keyboard yet ... so I haven't tried this fix myself. Will update once I got the Neo keyboard correctly added.
/cc @Snaptags and @MovGP0, can you please try out this fix on your Neo keyboard?