Update-PSResource fails with required nuget version

[ThomasNieto]

Prerequisites

• Write a descriptive title.
• Make sure you are able to repro it on the latest released version
• Search the existing issues.

Steps to reproduce

If you try and Update-PSResource using a nuget version syntax it fails, Install-PSResource works. This workflow worked in beta22 so something has changed to break it.

I found this while running CI for my module: CI run

PS C:\Users\Thomas> Install-PSResource -Name NetworkingDsc -Version '[8.0.0]' -PassThru

Name          Version Prerelease Repository Description
----          ------- ---------- ---------- -----------
NetworkingDsc 8.0.0              PSGallery  DSC resources for configuring settings related to networking.

PS C:\Users\Thomas> Update-PSResource -Name NetworkingDsc -Version '[8.1.0]' -PassThru

Name          Version Prerelease Repository Description
----          ------- ---------- ---------- -----------
NetworkingDsc 8.1.0              PSGallery  DSC resources for configuring settings related to networking.

PS C:\Users\Thomas> Update-PSResource -Name NetworkingDsc -Version '[8.2.0-preview0001]' -PassThru
Update-PSResource: Package 'NetworkingDsc' with version '[8.2.0-preview0001]' could not be found
WARNING: Installed package 'NetworkingDsc':'[8.2.0-preview0001]' was not found in repositories and cannot be updated.

PS C:\Users\Thomas> Update-PSResource -Name NetworkingDsc -Version '[8.2.0-preview0001]' -PassThru -Prerelease
Update-PSResource: Package 'NetworkingDsc' with version '[8.2.0-preview0001]' could not be found
WARNING: Installed package 'NetworkingDsc':'[8.2.0-preview0001]' was not found in repositories and cannot be updated.

Expected behavior

# works

Actual behavior

Update-PSResource -Name NetworkingDsc -Version '[8.2.0-preview0001]' -PassThru -Prerelease
Update-PSResource: Package 'NetworkingDsc' with version '[8.2.0-preview0001]' could not be found
WARNING: Installed package 'NetworkingDsc':'[8.2.0-preview0001]' was not found in repositories and cannot be updated.

Error details

Exception             :
    Type           : Microsoft.PowerShell.PSResourceGet.UtilClasses.PackageNotFoundException
    Message        : Package 'NetworkingDsc' with version '[8.2.0-preview0001]' could not be found
    InnerException :
        Type    : Microsoft.PowerShell.PSResourceGet.UtilClasses.V2ResourceNotFoundException
        Message : Package does not exist on the server
        HResult : -2146233088
    HResult        : -2146233088
TargetObject          : Microsoft.PowerShell.PSResourceGet.Cmdlets.FindHelper
CategoryInfo          : InvalidResult: (Microsoft.PowerShel….Cmdlets.FindHelper:FindHelper) [Update-PSResource],
PackageNotFoundException
FullyQualifiedErrorId : FindNameConvertToPSResourceFailure,Microsoft.PowerShell.PSResourceGet.Cmdlets.UpdatePSResource
InvocationInfo        :
    MyCommand        : Update-PSResource
    ScriptLineNumber : 1
    OffsetInLine     : 1
    HistoryId        : 4
    Line             : Update-PSResource -Name NetworkingDsc -Version '[8.2.0-preview0001]' -PassThru -Prerelease
    Statement        : Update-PSResource -Name NetworkingDsc -Version '[8.2.0-preview0001]' -PassThru -Prerelease
    PositionMessage  : At line:1 char:1
                       + Update-PSResource -Name NetworkingDsc -Version '[8.2.0-preview0001]'  …
                       + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    InvocationName   : Update-PSResource
    CommandOrigin    : Internal
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo :

Environment data

beta23

Visuals

No response

[SydneyhSmith]

Thanks @ThomasNieto, we should also check our tests, as a test should have caught this regression

[ThomasNieto]

@SydneyhSmith feel free to compare to my tests for anypackage/psresourceget to see if there are any gaps.

[alerickson]

Just working on the bug fix for this we did have a test to check for this scenario. Running the test locally it fails before the bug fix and is resolved after the bug fix. I don't know how this test didn't fail in CI, but from what I'm looking at it both should always be a test that's run and should definitely have failed.

[ThomasNieto]

In that linked test I don't see where it is specifying the required version using the square bracket syntax. Am I missing something?

[alerickson]

@ThomasNieto to backtrack a bit, I was looking at tests to see if we had anything to catch this bug and I saw the test I linked to above. It's different than your original issue but fails because of the same underlying problem (the -Prerelease param not getting passed through). So that's the context around that comment. Ideally this test should have caught that regression but for some reason didn't (ie it's failing locally as it should and passing in CI even though it shouldn't).

The reason why the test linked to is similar to your issue is because they both treat the version for the package to be updated to as a version range, which follows a different code path than a "specific version" (ie "9.0.0" instead of "[9.0.0]").

I opened a dummy PR here, to try to figure out why CI is giving a false positive, in the hopes of properly fixing that test and having it act as a (properly working) test for the linked PR I opened, but I still can't quite figure out what's going on there. So I'll just add a test to the PR with the bracket syntax.