New-NugetPackage fails on german dotnet core (win)

[jmarkert]

Steps to reproduce

Publishing a module to my private PSRepositoy (Nexus3) fails. I'm not sure, but I guess it is broken since I have upgraded PScore from 6.1 to 6.2

Publish-Module -Path ".\dest\$ModuleName\$version\" -Repository $MyPrivateRepo -NuGetApiKey $NuGetApiKey -Credential $Credential

Actual behavior

Publish-PSArtifactUtility : Failed to generate the compressed file for module 'Cannot index into a null array.'.
At C:\program files\powershell\6\Modules\PowerShellGet\PSModule.psm1:10785 char:17
+ ...             Publish-PSArtifactUtility @PublishPSArtifactUtility_Param ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : InvalidOperation: (:) [Write-Error], WriteErrorException
+ FullyQualifiedErrorId : FailedToCreateCompressedModule,Publish-PSArtifactUtility

I debugged the process and found the problem in the New-NugetPackage function
https://github.com/PowerShell/PowerShellGet/blob/7de99ee0c38611556e5c583ffaca98bb1922a0d4/src/PowerShellGet/private/functions/New-NugetPackage.ps1#L119

dotnet.exe returns and localized string, so the -match does not work. For the positive match in german the expression should be something like:

'Das Paket "(.*.nupkg)" wurde erfolgreich erstellt.' 

For testing I have changed the expression and the package creation gets recognized correctly.

Environment data

I'am on german Windows 10 1903

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.2.1
PSEdition                      Core
GitCommitId                    6.2.1
OS                             Microsoft Windows 10.0.18362
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

> Get-Module -ListAvailable PowerShellGet,PackageManagement
    Directory: C:\program files\powershell\6\Modules

ModuleType Version    Name                                PSEdition ExportedCommands
---------- -------    ----                                --------- ----------------
Script     1.3.2      PackageManagement                   Desk      {Find-Package, Get-Package, Get-PackageProvider, Get-PackageSource…}
Script     2.1.3      PowerShellGet                       Desk      {Find-Command, Find-DSCResource, Find-Module, Find-RoleCapability…}

> Get-PackageProvider -ListAvailable
Name                     Version          DynamicOptions
----                     -------          --------------
NuGet                    3.0.0.1          Destination, ExcludeVersion, Scope, SkipDependencies, Headers, FilterOnTag, Contains, AllowPrereleaseVersions, ConfigFile, SkipValidate
PowerShellGet            2.1.3.0          PackageManagementProvider, Type, Scope, AllowClobber, SkipPublisherCheck, InstallUpdate, NoPathUpdate, AllowPrereleaseVersions, Filter, Tag, Includes, DscResource, RoleCapability, Command, Acce…

It looks like there is another issue when publishing it to the repo (Publish-NugetPackage). The package gets pushed correctly but an error is returned.

...
info : Ihr Paket wurde per Push übertragen.

Failed to publish module 'mymodule': 'nuget.exe failed to push Im nicht interaktiven Modus kann keine Eingabeaufforderung erfolgen.
'.
At C:\program files\powershell\6\Modules\PowerShellGet\PSModule.psm1:10784 char:17
+ ...             Publish-PSArtifactUtility @PublishPSArtifactUtility_Param ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [Write-Error], WriteErrorException
    + FullyQualifiedErrorId : FailedToPublishTheModule,Publish-PSArtifactUtility

[SydneyhSmith]

@jmarkert thanks for reporting this issue, and for the debugging work you have done...you mention that in testing you were able to have success by changing an expression-- would you be able to share what the specific change was that you made?

[jmarkert]

Sorry for the confusion, I just changed it to the expression for the german output: so line 119 looks like
$stdOut -match 'Das Paket "(.*.nupkg)" wurde erfolgreich erstellt.' | Out-Null
which of course will break it on other languages.

[SydneyhSmith]

Thanks @jmarkert sounds like we may need to generalize to "(.*.nupkg)" but we will need to do some more investigation

[CXuesong]

I came here as I've seen the similar issue. Perhaps we may force CLI output in English, but I'm not sure how to do this.

PS> Publish-Module -Path:$RedistDir -Repository:$RepositoryName -NuGetApiKey:$ApiKey -Verbose
VERBOSE: Acquiring providers for assembly: C:\program files\powershell\7-preview\Modules\PackageManagement\coreclr\netstandard2.0\Microsoft.PackageManagement.ArchiverProviders.dll
VERBOSE: Acquiring providers for assembly: C:\program files\powershell\7-preview\Modules\PackageManagement\coreclr\netstandard2.0\Microsoft.PackageManagement.CoreProviders.dll
VERBOSE: Acquiring providers for assembly: C:\program files\powershell\7-preview\Modules\PackageManagement\coreclr\netstandard2.0\Microsoft.PackageManagement.MetaProvider.PowerShell.dll
VERBOSE: Acquiring providers for assembly: C:\program files\powershell\7-preview\Modules\PackageManagement\coreclr\netstandard2.0\Microsoft.PackageManagement.NuGetProvider.dll
VERBOSE: Repository details, Name = 'PSGallery', Location = 'https://www.powershellgallery.com/api/v2'; IsTrusted = 'False'; IsRegistered = 'True'.
VERBOSE: Repository details, Name = 'PSGallery', Location = 'https://www.powershellgallery.com/api/v2'; IsTrusted = 'False'; IsRegistered = 'True'.
VERBOSE: Publish Location:'https://www.powershellgallery.com/api/v2/package/'.
VERBOSE: Module 'PSMWUpdater' was found in 'E:\My Files\Visual Studio 2019\Projects\PSMWUpdater\PSMWUpdater\bin\Redist\PSMWUpdater'.
VERBOSE: Repository details, Name = 'PSGallery', Location = 'https://www.powershellgallery.com/api/v2'; IsTrusted = 'False'; IsRegistered = 'True'.
VERBOSE: Using the provider 'PowerShellGet' for searching packages.
VERBOSE: Using the specified source names : 'PSGallery'.
VERBOSE: Getting the provider object for the PackageManagement Provider 'NuGet'.
VERBOSE: The specified Location is 'https://www.powershellgallery.com/api/v2/items/psscript' and PackageManagementProvider is 'NuGet'.
VERBOSE: Searching repository 'https://www.powershellgallery.com/api/v2/items/psscript/FindPackagesById()?id='PSMWUpdater'' for ''.
VERBOSE: Total package yield:'0' for the specified package 'PSMWUpdater'.
VERBOSE: Repository details, Name = 'PSGallery', Location = 'https://www.powershellgallery.com/api/v2'; IsTrusted = 'False'; IsRegistered = 'True'.
VERBOSE: Using the provider 'PowerShellGet' for searching packages.
VERBOSE: Using the specified source names : 'PSGallery'.
VERBOSE: Getting the provider object for the PackageManagement Provider 'NuGet'.
VERBOSE: The specified Location is 'https://www.powershellgallery.com/api/v2' and PackageManagementProvider is 'NuGet'.
VERBOSE: Searching repository 'https://www.powershellgallery.com/api/v2/FindPackagesById()?id='PSMWUpdater'' for ''.
VERBOSE: Total package yield:'0' for the specified package 'PSMWUpdater'.
VERBOSE: Performing the operation "Publish-Module" on target "Version '1.0.0' of module 'PSMWUpdater'".
VERBOSE: Calling Publish-PSArtifactUtility
VERBOSE: Calling New-NuspecFile
VERBOSE: Calling New-NugetPackage
VERBOSE: Calling C:\Program Files\dotnet\dotnet.exe pack "~\AppData\Local\Temp\617ee336-a326-444e-b627-e5f73281abbd\Temp.csproj" /p:NuspecFile="~\AppData\Local\Temp\1937237968\PSMWUpdater\PSMWUpdater.nuspec" --output "~\AppData\Local\Temp\1937237968\PSMWUpdater"
VERBOSE: C:\Program Files\dotnet\dotnet.exe output:
VERBOSE:        用于 .NET Core 的 Microsoft (R) 生成引擎版本 16.4.0+e901037fe
VERBOSE:        版权所有(C) Microsoft Corporation。保留所有权利。
VERBOSE:
VERBOSE:          ~\AppData\Local\Temp\617ee336-a326-444e-b627-e5f73281abbd\Temp.csproj 的还原在 221.27 ms 内完成。
VERBOSE:          Temp -> ~\AppData\Local\Temp\617ee336-a326-444e-b627-e5f73281abbd\bin\Debug\netcoreapp2.0\NotUsed.dll
VERBOSE:          已成功创建包“~\AppData\Local\Temp\1937237968\PSMWUpdater\PSMWUpdater.1.0.0.nupkg”。
VERBOSE:        C:\Program Files\dotnet\sdk\3.1.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5100: 程序集“AsyncEnumerableExtensions.dll”不在 "lib" 文件夹
内，因此将包安装到项目中后，不能将该程序集添加为引用。如需引用，请将其移动到 "lib" 文件夹。 [~\AppData\Local\Temp\617ee336-a326-444e-b627-e5f73281abbd\Temp.csproj]
VERBOSE:        C:\Program Files\dotnet\sdk\3.1.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5100: 程序集“Microsoft.Extensions.Logging.Abstractions.dll” 
不在 "lib" 文件夹内，因此将包安装到项目中后，不能将该程序集添加为引用。如需引用，请将其移动到 "lib" 文件夹。 [~\AppData\Local\Temp\617ee336-a326-444e-b627-e5f73281abbd\Temp.csproj]    
VERBOSE:        C:\Program Files\dotnet\sdk\3.1.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5100: 程序集“Newtonsoft.Json.dll”不在 "lib" 文件夹内，因此将
包安装到项目中后，不能将该程序集添加为引用。如需引用，请将其移动到 "lib" 文件夹。 [~\AppData\Local\Temp\617ee336-a326-444e-b627-e5f73281abbd\Temp.csproj]
VERBOSE:        C:\Program Files\dotnet\sdk\3.1.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5100: 程序集“PSMWUpdater.dll”不在 "lib" 文件夹内，因此将包安
装到项目中后，不能将该程序集添加为引用。如需引用，请将其移动到 "lib" 文件夹。 [~\AppData\Local\Temp\617ee336-a326-444e-b627-e5f73281abbd\Temp.csproj]
VERBOSE:        C:\Program Files\dotnet\sdk\3.1.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5100: 程序集“System.Interactive.Async.dll”不在 "lib" 文件夹 
内，因此将包安装到项目中后，不能将该程序集添加为引用。如需引用，请将其移动到 "lib" 文件夹。 [~\AppData\Local\Temp\617ee336-a326-444e-b627-e5f73281abbd\Temp.csproj]
VERBOSE:        C:\Program Files\dotnet\sdk\3.1.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5100: 程序集“System.Linq.dll”不在 "lib" 文件夹内，因此将包安
装到项目中后，不能将该程序集添加为引用。如需引用，请将其移动到 "lib" 文件夹。 [~\AppData\Local\Temp\617ee336-a326-444e-b627-e5f73281abbd\Temp.csproj]
VERBOSE:        C:\Program Files\dotnet\sdk\3.1.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5100: 程序集“System.Management.Automation.dll”不在 "lib" 文 
件夹内，因此将包安装到项目中后，不能将该程序集添加为引用。如需引用，请将其移动到 "lib" 文件夹。 [~\AppData\Local\Temp\617ee336-a326-444e-b627-e5f73281abbd\Temp.csproj]
VERBOSE:        C:\Program Files\dotnet\sdk\3.1.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5100: 程序集“System.Threading.dll”不在 "lib" 文件夹内，因此
将包安装到项目中后，不能将该程序集添加为引用。如需引用，请将其移动到 "lib" 文件夹。 [~\AppData\Local\Temp\617ee336-a326-444e-b627-e5f73281abbd\Temp.csproj]
VERBOSE:        C:\Program Files\dotnet\sdk\3.1.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): warning NU5100: 程序集“WikiClientLibrary.dll”不在 "lib" 文件夹内，因此
将包安装到项目中后，不能将该程序集添加为引用。如需引用，请将其移动到 "lib" 文件夹。 [~\AppData\Local\Temp\617ee336-a326-444e-b627-e5f73281abbd\Temp.csproj]
VERBOSE: finished running C:\Program Files\dotnet\dotnet.exe with exit code 0
Write-Error: C:\program files\powershell\7-preview\Modules\PowerShellGet\PSModule.psm1
 Line |
10944 |                 Publish-PSArtifactUtility @PublishPSArtifactUtility_Params
      |                 ^ Failed to generate the compressed file for module 'Cannot index into a null array.'.

[jmarkert]

Hopefully there are exit codes to rely on.

[CXuesong]

I don't think exit codes are enough. PowerShellGet needs to know where is the built package placed in. That's why the following statement exists.

$stdOut -match "Successfully created package '(.*.nupkg)'" | Out-Null 

[KUTlime]

@SydneyhSmith Guys, could you do "the investigation" more quickly?

I can confirm @jmarkert conclusion. Same problem on the Czech version environment.
I've just lost 3 hours of my life because of that.

I'm giving you the best possible solution in my PR.

[paule96]

I think the solution is to set the environment variable DOTNET_CLI_UI_LANGUAGE to en but the dotnet pack command that is used ignore it...

[paule96]

What's realy helping for me was the following:

$languagesToRemove = @("de", "de-Deu");
 Get-ChildItem -Path "C:\Program Files\dotnet" -Recurse -Directory -Include $languagesToRemove  | rm -Recurse

Run this as admin and you can run the publish... very sad stuff... Hope someone fix issue in the dotnet pack command.

[KUTlime]

@paule96 This could be one solution but it is just covering the true problem that is a poor design of generated package search.

Sadly, even after 7 weeks, this no solution is provided in the main repository. I had to publish module updates via hacked version of this module. :-(

[paule96]

yes I know. I'm currently so happy our build agents are English VMs...

[Stephanevg]

Hi @SydneyhSmith do you know if someone is working on this one? It seems open since a long time...
I am facing the same issue on MacOS I think (see here PowerShell/PowerShellGetv2#606 )

[Stephanevg]

Ha, it looks there was a PR for this -> PowerShell/PowerShellGetv2#567
Is actually somebody working on this project?

[alerickson]

Hi @Stephanevg, no one is actively working on this repo. I'm currently working on publish functionality for the v3 version of PowerShellGet. That should be released in the next week or two. We're only really accepting security PRs for this repo right now.

I'll transfer this issue to that repository so we can track it there.