Publish-PSResource flatten folder and file structure

[MVKozlov]

Prerequisites

• Write a descriptive title.
• Make sure you are able to repro it on the latest released version
• Search the existing issues.

Steps to reproduce

Publish-PSResource -Credential $Cred -Repository $Repo -Path $Path
$Path contains file tree but publish flatten it in nupkg

The problem triangled in #704
PowerShell/PowerShellGet@270d57e#diff-56bf43952db65da3734ae9fabbe720248ec3a4d18d87ee94ec8ce2b91bce4af1
line 354-359 vs 400-402

- var fileName = fileNamePath.Substring(_path.Length).Trim(_PathSeparators);
- var newFilePath = System.IO.Path.Combine(outputDir, fileName);
+ FileInfo fileInfo = new FileInfo(fileNamePath);
+ var newFilePath = System.IO.Path.Combine(outputDir, fileInfo.Name);

new one does not respect relative file path, only file name

Expected behavior

folder/file structure preserved
module.psd1
file1.ps1
public/
  file2.ps1
private/
  file3.ps1

Actual behavior

public/
private/
module.psd1
file1.ps1
file2.ps1
file3.ps1

Error details

No response

Environment data

Version    Name
-------    ----
3.0.17     PowerShellGet

Name                           Value
----                           -----
PSVersion                      7.2.6
PSEdition                      Core
GitCommitId                    7.2.6
OS                             Microsoft Windows 10.0.19043
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visuals

No response

[MVKozlov]

btw, v2 by default skip hidden files/folder such as .git , v3 is not

[alerickson]

@MVKozlov thanks for opening this issue! We'll try to get this fix in for our next release.

[MVKozlov]

@alerickson, I hope skipping hidden files/folders will be done too

[PaulHigin]

I also see this behavior. It breaks publishing PowerShellGet because our own module expects binaries to be in a subdirectory (netstandard2.0), so after publishing then installation, the PowerShellGet module does not work.

[MVKozlov]

@alerickson
To skip hidden directories and files I would use a strategy like this

1. Check attributes and don't create hidden directories
2. When adding files, check for the existence of the destination directory (and file attributes, of course, too)

[alerickson]

@MVKozlov I'm going to close this issue because the original issue (in title) is resolved. Feel free to open a new issue regarding skipping hidden directories and we can continue that conversation. Thanks!