Skip to content

Conversation

alerickson
Copy link
Member

PR Summary

Publish-PSResource now looks at ExternalModuleDependencies when checking that dependencies exist in the repository that the parent package is being published to. If modules are listed under ExternalModuleDependencies, they're removed from the list of dependencies that need to be searched for in the repository.

PR Context

Resolves #1245

PR Checklist

Copy link
Member

@anamnavi anamnavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alerickson alerickson merged commit c9b6601 into PowerShell:master Jul 18, 2023
@alerickson alerickson deleted the externalModules branch July 18, 2023 22:38
@SydneyhSmith SydneyhSmith added PR-Bug This pull request resolves an issue bug Release This pull request is part the next release labels Jul 25, 2023
@SydneyhSmith SydneyhSmith removed PR-Bug This pull request resolves an issue bug Release This pull request is part the next release labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish-PSResource does not take into account ExternalModuleDependencies, when checking dependencies

3 participants