Skip to content

Bug fix for updating to a prerelease module #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Bug fix for updating to a prerelease module #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60a6d6a
Set prerelease variable default value to Prerelease param value
alerickson Aug 1, 2023
aee0356
Change how prerelease is validated
alerickson Aug 1, 2023
b2f6280
Add test
alerickson Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/code/UpdatePSResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ protected override void ProcessRecord()
nugetVersion: nugetVersion,
versionType: versionType,
versionString: Version,
prerelease: latestInstalledIsPrerelease,
prerelease: latestInstalledIsPrerelease || Prerelease,
repository: Repository,
acceptLicense: AcceptLicense,
quiet: Quiet,
Expand Down Expand Up @@ -331,7 +331,7 @@ private string[] ProcessPackageNames(
nugetVersion: nuGetVersion,
versionType: versionType,
version: Version,
prerelease: latestInstalledIsPrerelease,
prerelease: latestInstalledIsPrerelease || Prerelease,
tag: null,
repository: Repository,
includeDependencies: !SkipDependencyCheck))
Expand Down
18 changes: 18 additions & 0 deletions test/UpdatePSResourceTests/UpdatePSResourceV2Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,24 @@ Describe 'Test HTTP Update-PSResource for V2 Server Protocol' -tags 'CI' {
$isPkgUpdated | Should -Be $true
}

It "Update resource to explicit prerelease version using NuGet syntax" {
Install-PSResource -Name $testModuleName -Version "1.0.0.0" -Repository $PSGalleryName -TrustRepository
Update-PSResource -Name $testModuleName -Version "[5.2.5-alpha001]" -Prerelease -Repository $PSGalleryName -TrustRepository
$res = Get-InstalledPSResource -Name $testModuleName
$res | Should -Not -BeNullOrEmpty
$isPkgUpdated = $false
foreach ($pkg in $res)
{
if ([System.Version]$pkg.Version -eq [System.Version]"5.2.5")
{
$pkg.Prerelease | Should -Be "alpha001"
$isPkgUpdated = $true
}
}

$isPkgUpdated | Should -Be $true
}

It "Update prerelease version to a higher prerelease version not using -Prerelease parameter" {
Install-PSResource -Name $testModuleName3 -Version "0.0.99-beta1" -Repository $PSGalleryName -TrustRepository
Update-PSResource -Name $testModuleName3 -Repository $PSGalleryName -TrustRepository
Expand Down