Skip to content

Add acquiring ACR access token using Azure.Identity and allow unauthenticated ACR endpoints #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

adityapatwardhan
Copy link
Member

PR Summary

  • Acquire ACR access token using Azure.Identity
  • To acquire ACR access token we go through the following steps
    • Check if a credential is provided when registering the repository, if it then use it.
    • If no credential provided at registration then
      • Check if the ACR endpoint can be accessed without a token
      • If not, try using Azure.Identity to get the az access token, then ACR refresh token and then ACR access token.

PR Context

PR Checklist

@alerickson
Copy link
Member

resolves #1580

Copy link
Member

@anamnavi anamnavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan adityapatwardhan merged commit ed6da24 into PowerShell:master Mar 6, 2024
@adityapatwardhan adityapatwardhan deleted the AddAzAuth branch March 6, 2024 01:55
alerickson pushed a commit to alerickson/PSResourceGet that referenced this pull request Apr 1, 2024
alerickson pushed a commit to alerickson/PSResourceGet that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants