Script file info cmdlets #602
Conversation
… Hashtable[] RequiredModules
…ut variable for udpated one
…ves in AfterAll block
src/code/PSScriptFileInfo.cs
Outdated
| return false; | ||
| } | ||
|
|
||
| keyName = ""; |
There was a problem hiding this comment.
It looks like both keyName and value are only used within the for loop below. So they can be defined there (in that scope) instead of here.
There was a problem hiding this comment.
FYI, in the latest commit this is in a helper method GetMetadataFromCommentLines().
We need the keyName and value variables defined outside the for loop, as we're iterating through lines of the metadata string. When grabbing the key name and value, the value can continue onto the next line. So for certain metadata properties we may not get all the value on that line/within the current iteration of the for loop.
| var contentAfterAndIncludingDescription = totalFileContents.SkipWhile(x => !x.Contains(".DESCRIPTION")).ToList(); | ||
| var contentAfterDescription = contentAfterAndIncludingDescription.SkipWhile(x => !x.Contains("#>")).Skip(1).ToList(); | ||
| endOfFileContents = String.Join("\n", contentAfterDescription.ToArray()); | ||
| endOfFileContents = String.Join("\n", contentAfterAndIncludingDescription.SkipWhile(x => !x.Contains("#>")).Skip(1).ToArray()); |
There was a problem hiding this comment.
I am not sure about this. It is not clear what this is doing and whether script content, that can also include comments, is always included in endOfFileContents. Instead of using LINQ I would prefer to see a utility method that is a bit more explicit about what it is doing.
|
this PR willl be closed in favor of #708 |
3 participants
PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.