Skip to content

Bugfix for Update cmdlet attempting to reinstall latest preview version #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 28, 2022
Merged

Bugfix for Update cmdlet attempting to reinstall latest preview version #834

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c91f159
fix Update prerelease version comparision that results in reinstall o…
anamnavi Oct 18, 2022
1db00f0
add error handling for NuGetVersion.TryParse call
anamnavi Oct 18, 2022
e355e05
add comment about System.Version comparision discrepancy
anamnavi Oct 21, 2022
c781f2c
fix Update prerelease version comparision that results in reinstall o…
anamnavi Oct 18, 2022
945b8fd
add error handling for NuGetVersion.TryParse call
anamnavi Oct 18, 2022
9f2b295
add comment about System.Version comparision discrepancy
anamnavi Oct 21, 2022
5d31dd7
Merge branch 'master' of https://github.com/anamnavi/PowerShellGet in…
anamnavi Nov 3, 2022
9992f1e
Merge branch 'prerelease-update-bug' of https://github.com/anamnavi/P…
anamnavi Nov 3, 2022
02585c5
add version to verbose message
anamnavi Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/code/UpdatePSResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,14 +354,22 @@ private string[] ProcessPackageNames(
continue;
}

if ((versionRange == VersionRange.All && repositoryPackage.Version > installedPackage.Version) ||
if (!NuGetVersion.TryParse(repositoryPackage.Version.ToString(), out NuGetVersion repositoryPackageNuGetVersion))
{
WriteWarning($"Cannot parse nuget version in repository package '{repositoryPackage.Name}'. Cannot update package.");
continue;
}

// We compare NuGetVersions instead of System.Version as repositoryPackage.Version (3.0.17.0) and installedPackage.Version (3.0.17.-1)
// should refer to the same version but with System.Version end up having discrepancies which yields incorrect results.
if ((versionRange == VersionRange.All && repositoryPackageNuGetVersion > installedVersion) ||
!versionRange.Satisfies(installedVersion))
{
namesToUpdate.Add(repositoryPackage.Name);
}
else
{
WriteVerbose($"Installed package {repositoryPackage.Name} is up to date.");
WriteVerbose($"Installed package {repositoryPackage.Name} {repositoryPackageNuGetVersion} is already up to date.");
}
}

Expand Down