AvoidUserNameAndPasswordParams should match exactly for "Username" and "Password" parameters

[JustinGrote]

In my usage it seems to match any parameter that has the word "Password" or "Username" contained therein without considering that parameter's usage.

For example, it will trigger saying this is not correct and requires securestring or credential:
Get-SensitiveInfo -HidePassword:$true -HideUsername:$true

I would send a pull request but I don't know C#, wasn't sure how to address the string matching :(

[kapilmb]

Thanks for bringing this to attention.

The rule checks if a parameter with password in its name is either of type securestring or pscredential or has the CredentialAttribute transformation attribute. That is why it flags a boolean type parameter too. I will open an issue to fix this such that it ignores the password parameter if it is of boolean type.

[JustinGrote]

Thanks, I would also recommend ignoring [Switch] type parameters as well, I just used the boolean as an example but normally I don't include the extra :$true

[kapilmb]

Since we are tracking the problem in #572, can I close I close this issue?

[JustinGrote]

Yes thank you.

On Mon, Jun 20, 2016 at 4:44 PM Kapil Borle notifications@github.com
wrote:

Since we are tracking the problem in #572
#572, can I close
I close this issue?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#571 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AOjVUiS2QmldMthe1P5g4pS4OUbEqrRmks5qNyXsgaJpZM4I5YqH
.