Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for parameter "Settings" of command "Invoke-ScriptAnalyzer" to include the key "RecurseCustomRulesPath" #1272

Conversation

travisclagrone
Copy link
Contributor

@travisclagrone travisclagrone commented Jun 23, 2019

Fixes #1270 "Documentation for Invoke-ScriptAnalyzer -Settings is out-of-date".

…ptAnalyzer" to include the key "RecurseCustomRulesPath"
Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, what about sorting the parameters alphabetically?
Also, if you use an issue closing keyword in the description, then the issue gets closed automatically:
https://help.github.com/en/articles/closing-issues-using-keywords

@travisclagrone
Copy link
Contributor Author

travisclagrone commented Jun 29, 2019

@bergmeister

Looks good to me, what about sorting the parameters alphabetically?
Also, if you use an issue closing keyword in the description, then the issue gets closed automatically:
https://help.github.com/en/articles/closing-issues-using-keywords

Done and done.

@bergmeister bergmeister merged commit 88056ac into PowerShell:master Jun 29, 2019
@travisclagrone travisclagrone deleted the update-documentation-for-Invoke-ScriptAnalyzer_-Settings branch June 29, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for Invoke-ScriptAnalyzer -Settings is out-of-date
2 participants