Skip to content

change release build to be more specific with regard to the assemblies to check with binskim #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2021
Merged

change release build to be more specific with regard to the assemblies to check with binskim #1703

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
026bb90
Binskim should only check the assemblies we provide as part of analyzer
JamesWTruher Aug 16, 2021
fb7abad
add pluralize.net.dll to assemblies that need 3rd party signing.
JamesWTruher Aug 16, 2021
0c49c24
be sure to include minimatch option
JamesWTruher Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .ci/releaseBuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,12 @@ stages:
# the certificate ID to use
# we'll need to change this to the 3rd party cert id
certificateId: "CP-231522"
# the file pattern to use - only sign newtonsoft
pattern: 'Newtonsoft*.dll'
# use minimatch because we need to exclude the NewtonSoft assembly
useMinimatch: true
# the file pattern to use - only sign newtonsoft and pluralize
pattern: |
**/Pluralize*.dll
**/Newtonsoft*.dll

# now create the nupkg which we will use to publish the module
# to the powershell gallery (not part of this yaml)
Expand Down Expand Up @@ -173,7 +177,7 @@ stages:
# component-governance - the path to sources
sourceScanPath: '$(Build.SourcesDirectory)/OSS_Microsoft_PSSA'
# binskim - this isn't recursive, so you need the path to the assemblies
AnalyzeTarget: '$(Pipeline.Workspace)\build\bin\PSV7Release\netcoreapp3.1\*.dll'
AnalyzeTarget: '$(Pipeline.Workspace)\build\bin\PSV7Release\netcoreapp3.1\Microsoft.Windows.PowerShell.ScriptAnalyzer*.dll'
# credscan - scan the repo for credentials
# you can suppress some files with this.
suppressionsFile: '$(Build.SourcesDirectory)/OSS_Microsoft_PSSA/tools/ReleaseBuild/CredScan.Suppressions.json'
Expand Down