Skip to content

Edited WriteHost rule strings. #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2015
Merged

Edited WriteHost rule strings. #349

merged 1 commit into from
Nov 6, 2015

Conversation

juneb
Copy link
Contributor

@juneb juneb commented Nov 6, 2015

This should REPLACE the previous pull request. I think it has all of the required files.

@msftclas
Copy link

msftclas commented Nov 6, 2015

Hi @juneb, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@juneb
Copy link
Contributor Author

juneb commented Nov 6, 2015

This attempt has both changed files, but it's still failing. Please let me know how to fix it.

@raghushantha
Copy link
Member

Hi June. Can you please Sign the CLA? I will accept the PR and fix the failing test

https://github.com/PowerShell/PSScriptAnalyzer/blob/development/Tests/Rules/AvoidUsingWriteHost.tests.ps1

@raghushantha raghushantha self-assigned this Nov 6, 2015
@msftclas
Copy link

msftclas commented Nov 6, 2015

@juneb, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

raghushantha added a commit that referenced this pull request Nov 6, 2015
Edited WriteHost rule strings.
@raghushantha raghushantha merged commit 06d4972 into PowerShell:development Nov 6, 2015
@raghushantha
Copy link
Member

Hi June. Thank you for the message updates. Looking forward for more great content from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants