Skip to content

Make minor improvements to fixing mechanism #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2017

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented Jun 17, 2017

No description provided.

Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a ReadOnlyCollection that lets you wrap any IEnumerable:

https://msdn.microsoft.com/en-us/library/ms132474(v=vs.110).aspx

Any reason to avoid using that one? Doesn't matter really, just pointing that out :)

@kapilmb
Copy link
Author

kapilmb commented Jun 17, 2017

I think using ReadOnlyCollections is definitely a better approach. Will make the necessary changes. Thanks for the suggestion!

@kapilmb kapilmb force-pushed the kapilmb/update-formatter branch from 84a9dcc to 4c15216 Compare June 17, 2017 18:58
@kapilmb kapilmb merged commit 662d961 into development Jun 17, 2017
@kapilmb kapilmb deleted the kapilmb/update-formatter branch June 17, 2017 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants