Fix PSUseDeclaredVarsMoreThanAssignments when variable is assigned more than once to still give a warning #836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve Issue #833
Consider the case
$a=1;$a=2
. Then theinAssignment
will be false for the 2nd ast becausevarsInAssignment
already contains unly assignments to unique variables. Therefore no warning was produced. This PR makes it output a warning correctly by trying to cast it to anAssignmentStatementAst
an then checks the text to see if it is actually the same variable.