Have a single point of reference for the .Net Core SDK version #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmeister
changed the title
…nalyzer into SinglePointOReferenceForSdkVersion
… Get-Content or ConvertFrom-Json
bergmeister
changed the title
…nalyzer into SinglePointOReferenceForSdkVersion
JamesWTruher
approved these changes
Feb 20, 2018
| if (-not ((dotnet --version).StartsWith('2.1.4'))) | ||
| $globalDotJson = Get-Content .\global.json -Raw | ConvertFrom-Json | ||
| $dotNetCoreSDKVersion = $globalDotJson.sdk.version | ||
| if (-not ((dotnet --version).StartsWith($dotNetCoreSDKVersion))) |
There was a problem hiding this comment.
should we be specifying a specific version or just ensuring that the dotnet version is high enough?
There was a problem hiding this comment.
I don't have a strong opinion on this to be honest but if we regularly keep up with the latest SDKs we should not fall behind the versions in the Appveyor images any more. It's probably best to revisit when some of this code gets moved into build modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Remove the hard-coded SDK version in the
appeyor.ymlfile and parse theglobal.jsonfile instead so that the only place referencing the .Net Core SDK version isglobal.json.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.WIP:to the beginning of the title and remove the prefix when the PR is ready